Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial support for --ts-flat-files and --gen-all #7446

Merged
merged 4 commits into from
Aug 15, 2022
Merged

Partial support for --ts-flat-files and --gen-all #7446

merged 4 commits into from
Aug 15, 2022

Conversation

dbaileychess
Copy link
Collaborator

Addresses: #7445

@github-actions github-actions bot added c++ codegen Involving generating code from schema javascript python typescript labels Aug 15, 2022
@dbaileychess
Copy link
Collaborator Author

@bjornharrtell @jkuszmaul FYI

@github-actions github-actions bot added the grpc label Aug 15, 2022
jkuszmaul
jkuszmaul reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jkuszmaul jkuszmaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this is so straightforward. I thought there were more subtleties involved, but all the issues may just be in the namespacing stuff.

src/idl_gen_ts.cpp Show resolved Hide resolved
@dbaileychess
Copy link
Collaborator Author

Yeah, the namespacing adds a lot of the issue. But with a "well behaved" schema, it seems to work fairly simply.

@dbaileychess dbaileychess merged commit a66de58 into google:master Aug 15, 2022
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@dbaileychess
Partial support for --ts-flat-files and --gen-all (google#7446)
68b0d64 
* Partial support for --ts-flat-files and --gen-all

* Add generated code changes

* remove some debugging code left over

* missed grpc files
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@dbaileychess
Partial support for --ts-flat-files and --gen-all (google#7446)
f21c7e4 
* Partial support for --ts-flat-files and --gen-all

* Add generated code changes

* remove some debugging code left over

* missed grpc files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkuszmaul jkuszmaul jkuszmaul left review comments

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema grpc javascript python typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbaileychess @jkuszmaul