Fix a bug in the OpenGL backend that causes win32 errors not to be logged #8214 #8216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions are called in order to log it correctly. Prior to this change, intervening win32 API calls could clear the error code and it would not be logged.
|
FWIW in this particular case the bug causing PlatformWGL::makeCurrent() to fail was in my code. :D But this CL helped me figure that out by logging the windows errors correctly, so it's definitely worth submitting. |
poweifeng
approved these changes
Oct 21, 2024
pixelflinger
approved these changes
Oct 21, 2024
|
Thanks again, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you might imagine, I am submitting this change because I'm debugging a bug in the openGL backend, specifically one that causes PlatformWGL::makeCurrent() to fail if the swap chain is removed and created too many times. I hope that I can figure out the issue there, but if someone more familiar with this code could figure it out, that would be really cool... (If anyone is curious, wglMakeCurrent() is returning win32 error code 6.)