Add a warning for FRenderableManager #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, users set materials first without providing render primitives, which has incurred the attribute mismatching warning. This isn't helpful because users don't know what action they should take to remove the warning. Add a more specific warning for this case with which users know the direct cause and what to do to remove the warning. BUGS=[372755205]
pixelflinger
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Okay I understand the problem. I don't think we should have a warning when the handle is undefined -- that's an okay situation.
Instead, I think we should only emit the original "attribute mismatch" warning when the handle is defined. Otherwise we simply can't tell, so let's not print anything.
|
That also works. Let me update the change. |
z3moon
force-pushed
the
zm/add-warning
branch
from
e009433 to
726dfa9
Compare
pixelflinger
approved these changes
Oct 18, 2024
poweifeng
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, users set materials first without providing render primitives, which has incurred the attribute mismatching warning. This isn't helpful because users don't know what action they should take to remove the warning.
Emit the warning only when the primitive handle is initialized so the AttributeBitset is properly populated.
BUGS=[372755205]