Update hardware Handle #8187
Merged
Update hardware Handle #8187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain compilers, the assignment operators defined as default doesn't automatically make a call to the parent's method if it's expliclty defined. Make this beahvior explicit to avoid this edge case. BUGS=[371980551]
bejado
reviewed
Oct 9, 2024
Comment on lines
110
to
111
| // Explicitly redefine copy/move assignment operators rather than just using default here. | ||
| // Because it doesn't make a call to the parent's method automatically in certain compilers. |
There was a problem hiding this comment.
That's extremely strange. What compiler(s) are affected? What's the effect? Is HandleId object not copied correctly?
There was a problem hiding this comment.
This issue occurs when std::move(fences.begin() + 1, fences.end(), fences.begin()); is called (FrameSkipper.cpp:69) for specific NDK versions (<= 25.1.8937393, works fine from 26). Let me update the descriptions and comments.
pixelflinger
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain compilers, the assignment operators defined as default
doesn't automatically make a call to the parent's method if it's
user-defined.
Make this behavior explicit to avoid this edge case.
BUGS=[371980551]