matdbg: refactor EDIT command #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
force-pushed
the
pf/refactor-matdbg
branch
from
45cb964 to
d5dfc83
Compare
elizagamedev
approved these changes
Oct 11, 2023
pixelflinger
approved these changes
Oct 11, 2023
The websocket code for parsing the EDIT command is pretty verbose. Proposing that we move to a HTTP POST request instead. Also moved the API handler code out of DebugServer.h for clarity.
poweifeng
force-pushed
the
pf/refactor-matdbg
branch
from
d5dfc83 to
7498e35
Compare
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
The websocket code for parsing the EDIT command is pretty verbose. Proposing that we move to a HTTP POST request instead. Also moved the API handler code out of DebugServer.h for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The websocket code for parsing the EDIT command is pretty verbose. Proposing that we move to a HTTP POST request instead.
Also moved the API handler code out of DebugServer.h for clarity.