vk: layout transition clean up #7217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
poweifeng
commented
Sep 28, 2023
poweifeng
commented
- Return the correct SubresourceRange for depth attachments
- Fix transition for when one layout within mulitple mip-levels is different
- Use implicit layout transition for renderpasses
- Fix access mask for sampler in vertex shaders
- Use unordered_map for VkSubresourceRange in VulkanTexture
poweifeng
force-pushed
the
pf/vk-layout-changes
branch
from
a6e59b8 to
85a3eaa
Compare
- Return the correct SubresourceRange for depth attachments - Fix transition for when one layout within mulitple mip-levels is different - Use implicit layout transition for renderpasses - Fix access mask for sampler in vertex shaders - Use unordered_map for VkSubresourceRange in VulkanTexture
poweifeng
force-pushed
the
pf/vk-layout-changes
branch
from
85a3eaa to
92693a0
Compare
pixelflinger
approved these changes
Sep 28, 2023
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
- Return the correct SubresourceRange for depth attachments - Fix transition for when one layout within mulitple mip-levels is different - Use implicit layout transition for renderpasses - Fix access mask for sampler in vertex shaders - Use unordered_map for VkSubresourceRange in VulkanTexture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.