Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan: implicitly free command buffers #7167

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

poweifeng
Copy link
Contributor

We were calling vkFreeCommandBuffers directly, but resetting the buffers implicitly (when vkBeginCommandBuffer is called) seems to be a lot more performant.

Also, cleaned up destructor for VkBuffer to no longer require a separate terminate() method.

We were calling vkFreeCommandBuffers directly, but resetting
the buffers implicitly (when vkBeginCommandBuffer is called)
seems to be a lot more performant.

Also, cleaned up destructor for VkBuffer to no longer require
a separate terminate() method.
@poweifeng poweifeng added the internal Issue/PR does not affect clients label Sep 12, 2023
@poweifeng poweifeng merged commit ec30ddd into main Sep 13, 2023
11 checks passed
@poweifeng poweifeng deleted the pf/vk-implicit-free-cmdbuffer branch September 13, 2023 18:21
plepers pushed a commit to plepers/filament that referenced this pull request Dec 9, 2023
We were calling vkFreeCommandBuffers directly, but resetting
the buffers implicitly (when vkBeginCommandBuffer is called)
seems to be a lot more performant.

Also, cleaned up destructor for VkBuffer to no longer require
a separate terminate() method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants