Skip to content

Commit

Permalink
fix typo when generating the SSR pass
Browse files Browse the repository at this point in the history
this caused the HAS_SHADOWS flag to not be disabled, this didn't
actually cause a problem because shadowing and SSR share the same
SRE variant bit. But both should never be active together.
  • Loading branch information
pixelflinger committed Oct 8, 2024
1 parent 99b55cb commit 26b42a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion filament/src/PostProcessManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ FrameGraphId<FrameGraphTexture> PostProcessManager::ssr(FrameGraph& fg,
auto out = resources.getRenderPassInfo();

// Remove the HAS_SHADOWING RenderFlags, since it's irrelevant when rendering reflections
passBuilder.renderFlags(~RenderPass::HAS_SHADOWING, 0);
passBuilder.renderFlags(RenderPass::HAS_SHADOWING, 0);

// use our special SSR variant, it can only be applied to object that have
// the SCREEN_SPACE ReflectionMode.
Expand Down

0 comments on commit 26b42a7

Please sign in to comment.