Add missing setParameter variants to MaterialInstance (#6973)

Adds support for mat3/mat4 parameter types
google · Jul 20, 2023 · 176915b · 176915b
1 parent 0b60933
commit 176915b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/NEW_RELEASE_NOTES.md b/NEW_RELEASE_NOTES.md
@@ -7,3 +7,5 @@ for next branch cut* header.
 appropriate header in [RELEASE_NOTES.md](./RELEASE_NOTES.md).
 
 ## Release notes for next branch cut
+
+- web: Added missing setMat3Parameter()/setMat4Parameter() to MaterialInstance
diff --git a/web/filament-js/filament.d.ts b/web/filament-js/filament.d.ts
@@ -170,6 +170,8 @@ export class MaterialInstance {
     public setFloat2Parameter(name: string, value: float2): void;
     public setFloat3Parameter(name: string, value: float3): void;
     public setFloat4Parameter(name: string, value: float4): void;
+    public setMat3Parameter(name: string, value: mat4): void;
+    public setMat4Parameter(name: string, value: mat3): void;
     public setTextureParameter(name: string, value: Texture, sampler: TextureSampler): void;
     public setColor3Parameter(name: string, ctype: RgbType, value: float3): void;
     public setColor4Parameter(name: string, ctype: RgbaType, value: float4): void;

diff --git a/web/filament-js/jsbindings.cpp b/web/filament-js/jsbindings.cpp
@@ -1290,6 +1290,12 @@ class_<MaterialInstance>("MaterialInstance")
     .function("setFloat4Parameter", EMBIND_LAMBDA(void,
             (MaterialInstance* self, std::string name, filament::math::float4 value), {
         self->setParameter(name.c_str(), value); }), allow_raw_pointers())
+    .function("setMat3Parameter", EMBIND_LAMBDA(void,
+            (MaterialInstance* self, std::string name, filament::math::mat3f value), {
+        self->setParameter(name.c_str(), value); }), allow_raw_pointers())
+    .function("setMat4Parameter", EMBIND_LAMBDA(void,
+            (MaterialInstance* self, std::string name, filament::math::mat4f value), {
+        self->setParameter(name.c_str(), value); }), allow_raw_pointers())
     .function("setTextureParameter", EMBIND_LAMBDA(void,
             (MaterialInstance* self, std::string name, Texture* value, TextureSampler sampler), {
         self->setParameter(name.c_str(), value, sampler); }), allow_raw_pointers())