Remove the boolean to select transient

google · Sep 5, 2024 · 13bbf9a · 13bbf9a
1 parent f280b89
commit 13bbf9a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/filament/backend/src/vulkan/VulkanHandles.cpp b/filament/backend/src/vulkan/VulkanHandles.cpp
@@ -360,8 +360,7 @@ VulkanRenderTarget::VulkanRenderTarget(VkDevice device, VkPhysicalDevice physica
                 msTexture = new VulkanTexture(device, physicalDevice, context, allocator, commands,
                         texture->target, ((VulkanTexture const*) texture)->levels, texture->format,
                         samples, texture->width, texture->height, texture->depth, usage,
-                        stagePool, true /* heap allocated */, {} /* swizzle */,
-                        true /* preferTransientAttachment */);
+                        stagePool, true /* heap allocated */);
                 texture->setSidecar(msTexture);
             }
             mMsaaAttachments[index] = {.texture = msTexture};

diff --git a/filament/backend/src/vulkan/VulkanTexture.cpp b/filament/backend/src/vulkan/VulkanTexture.cpp
@@ -56,7 +56,7 @@ VulkanTexture::VulkanTexture(VkDevice device, VkPhysicalDevice physicalDevice,
         VulkanContext const& context, VmaAllocator allocator, VulkanCommands* commands,
         SamplerType target, uint8_t levels, TextureFormat tformat, uint8_t samples, uint32_t w,
         uint32_t h, uint32_t depth, TextureUsage tusage, VulkanStagePool& stagePool,
-        bool heapAllocated, VkComponentMapping swizzle, bool preferTransientAttachment)
+        bool heapAllocated, VkComponentMapping swizzle)
     : HwTexture(target, levels, samples, w, h, depth, tformat, tusage),
       VulkanResource(
               heapAllocated ? VulkanResourceType::HEAP_ALLOCATED : VulkanResourceType::TEXTURE),
@@ -106,8 +106,6 @@ VulkanTexture::VulkanTexture(VkDevice device, VkPhysicalDevice physicalDevice,
 
     // Determine if we can use the transient usage flag combined with lazily allocated memory.
     const bool useTransientAttachment =
-        // Transient attachment is requested.
-        preferTransientAttachment &&
         // Lazily allocated memory is available.
         context.isLazilyAllocatedMemorySupported() &&
         // Usage consists of attachment flags only.

diff --git a/filament/backend/src/vulkan/VulkanTexture.h b/filament/backend/src/vulkan/VulkanTexture.h
@@ -36,7 +36,7 @@ struct VulkanTexture : public HwTexture, VulkanResource {
             VmaAllocator allocator, VulkanCommands* commands, SamplerType target, uint8_t levels,
             TextureFormat tformat, uint8_t samples, uint32_t w, uint32_t h, uint32_t depth,
             TextureUsage tusage, VulkanStagePool& stagePool, bool heapAllocated = false,
-            VkComponentMapping swizzle = {}, bool preferTransientAttachment = false);
+            VkComponentMapping swizzle = {});
 
     // Specialized constructor for internally created textures (e.g. from a swap chain)
     // The texture will never destroy the given VkImage, but it does manages its subresources.