Nit: kebab-case for html names #1216

whaught · 2020-12-08T00:29:25Z

Proposed Changes

HTML is typically not case-sensitive
- We have examples of CamelCase, snake_case, and kebab-case. We should be consistent. Google prefers snake-case

google-oss-robot · 2020-12-08T00:41:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

whaught added 2 commits December 7, 2020 16:16

Nit: all lowercase

8b76fb0

all kebab case

8713ac8

google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 8, 2020

google-oss-robot requested review from mikehelmick and sethvargo December 8, 2020 00:29

google-oss-robot added approved Auto: added by prow when enough reviewers approve. size/L Auto: large number of changes. labels Dec 8, 2020

whaught assigned sethvargo Dec 8, 2020

mikehelmick approved these changes Dec 8, 2020

View reviewed changes

google-oss-robot assigned mikehelmick Dec 8, 2020

google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Dec 8, 2020

google-oss-robot merged commit 8c5749a into google:main Dec 8, 2020

whaught deleted the kebab-nit branch December 8, 2020 00:43

github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020