Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Remove feature flags for audience checking #1175

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

sethvargo
Copy link
Member

Fixes #1127

Release Note

**Potentially breaking** - Remove feature flags for audience checking - audience checking is always enforced for all HAs.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot added the approved Auto: added by prow when enough reviewers approve. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 19, 2020
@google-oss-robot google-oss-robot added the size/S Auto: small number of changes. label Nov 19, 2020
@mikehelmick
Copy link
Contributor

/hold
/lgtm
until closer to v0.17.0 cut

@google-oss-robot google-oss-robot added the do-not-merge/hold Do not merge: held by author or reviewer. label Nov 19, 2020
@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Nov 19, 2020
@mikehelmick mikehelmick added this to the v0.17.0 milestone Nov 19, 2020
@mikehelmick
Copy link
Contributor

/hold cancel
prep for v0.17.0 next week

@google-oss-robot google-oss-robot removed the do-not-merge/hold Do not merge: held by author or reviewer. label Nov 21, 2020
@sethvargo
Copy link
Member Author

/retest

1 similar comment
@sethvargo
Copy link
Member Author

/retest

@google-oss-robot google-oss-robot merged commit 45f3642 into main Nov 21, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/default_aud branch November 21, 2020 16:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/S Auto: small number of changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FEATURE_FAIL_ON_CERTIFICATE_AUDIENCE_MISMATCH
3 participants