Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

adjust symptom onset handling #1131

Merged
merged 5 commits into from
Nov 10, 2020
Merged

Conversation

mikehelmick
Copy link
Contributor

@mikehelmick mikehelmick commented Oct 30, 2020

Proposed Changes

  • "unreasonable" symptom onset intervals < 28d ago by default will be treated as if 0 is passed in.
  • keys with a valid symptom onset interval but fall outside the range of -14d..14d will be dropped (restores old / correct behavior.) THIS IS A CHANGE - currently those keys would get adjusted to nil, which would cause default
  • if NO symptom onset date is passed in, we tread the symptom onset day as 4 days ago and adjust the data on the TEKs accordingly

This modeling is being adjusted in consultation with the Apple+Google clinical teams working on EN.

Release Note

BEHAVIOR CHANGE: The handling of symptom onset intervals is changing. Any symptom onsets older than 28 days ago (rounded down to UTC midnight) will be treated as invalid and as if 0 was passed in. Keys with a valid symptom onset days outside of -14..14 will be dropped. If there is not symptom onset passed, the symptom onset interval is set to 4 days ago.
Timing flags can be adjusted via environment variables. Default values are recommended.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 30, 2020
@google-oss-robot google-oss-robot added approved Auto: added by prow when enough reviewers approve. size/L Auto: large number of changes. labels Oct 30, 2020
@mikehelmick
Copy link
Contributor Author

/hold
until monday - want to give people a chance to comment

@google-oss-robot google-oss-robot added do-not-merge/hold Do not merge: held by author or reviewer. size/XL Auto: extra large number of changes. and removed size/L Auto: large number of changes. labels Oct 30, 2020
@mikehelmick mikehelmick requested review from whaught and removed request for icco November 10, 2020 06:10
@mikehelmick
Copy link
Contributor Author

/hold cancel

@google-oss-robot google-oss-robot removed the do-not-merge/hold Do not merge: held by author or reviewer. label Nov 10, 2020
@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Nov 10, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit b3ac176 into google:main Nov 10, 2020
@mikehelmick mikehelmick deleted the testparams branch November 10, 2020 17:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/XL Auto: extra large number of changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants