This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
write generated export padding to the database, ensure overlapping ex… #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ports contain same data
google-oss-robot
added
the
approved
google-cla
bot
added
the
cla: yes
|
ready to review but putting a |
google-oss-robot
added
the
do-not-merge/hold
sethvargo
reviewed
Oct 29, 2020
| // MultiLock obtains multiple locks in a single transaction. Either all locks are obtained, or | ||
| // the transaction is rolled back. | ||
| // The lockIDs are sorted by normal ascending string sort order before obtaining the locks. | ||
| func (db *DB) MultiLock(ctx context.Context, lockIDs []string, ttl time.Duration) (UnlockFn, error) { |
There was a problem hiding this comment.
Is this so we can lock across multiple tables? It's unclear to me why we don't just use a transaction instead.
There was a problem hiding this comment.
added comments to worker.go where we take the locks
|
/cancel hold |
|
/unhold |
google-oss-robot
removed
the
do-not-merge/hold
sethvargo
approved these changes
Oct 29, 2020
google-oss-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel nope - this is good to go |
google-oss-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ports contain same data
Proposed Changes
Release Note