Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add export importers to the admin console #1085

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

sethvargo
Copy link
Member

Fixes #1081 Release Note

Add export importers to the admin console

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 15, 2020
@google-oss-robot google-oss-robot added the approved Auto: added by prow when enough reviewers approve. label Oct 15, 2020
@sethvargo
Copy link
Member Author

/assign @mikehelmick

@google-oss-robot google-oss-robot added the size/XL Auto: extra large number of changes. label Oct 15, 2020

if err := db.db.InTx(ctx, pgx.RepeatableRead, func(tx pgx.Tx) error {
row := tx.QueryRow(ctx,
`SELECT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move the ` up to the previous line

@mikehelmick
Copy link
Contributor

/lgtm
/hold

You can decide if you want to address the one optional comment.

@google-oss-robot google-oss-robot added do-not-merge/hold Do not merge: held by author or reviewer. lgtm Auto: added by prown with a reviewer LGTMs labels Oct 15, 2020
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot google-oss-robot removed the lgtm Auto: added by prown with a reviewer LGTMs label Oct 15, 2020
@sethvargo sethvargo added lgtm Auto: added by prown with a reviewer LGTMs and removed do-not-merge/hold Do not merge: held by author or reviewer. labels Oct 15, 2020
@google-oss-robot google-oss-robot merged commit 5ddd4aa into main Oct 15, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/export_import_config branch October 15, 2020 22:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/XL Auto: extra large number of changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants