This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 312
Add export importers to the admin console #1085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-cla
bot
added
the
cla: yes
Auto: added by CLA bot when all committers have signed a CLA.
label
Oct 15, 2020
google-oss-robot
added
the
approved
Auto: added by prow when enough reviewers approve.
label
Oct 15, 2020
/assign @mikehelmick |
mikehelmick
reviewed
Oct 15, 2020
|
||
if err := db.db.InTx(ctx, pgx.RepeatableRead, func(tx pgx.Tx) error { | ||
row := tx.QueryRow(ctx, | ||
`SELECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move the ` up to the previous line
/lgtm You can decide if you want to address the one optional comment. |
google-oss-robot
added
do-not-merge/hold
Do not merge: held by author or reviewer.
lgtm
Auto: added by prown with a reviewer LGTMs
labels
Oct 15, 2020
New changes are detected. LGTM label has been removed. |
sethvargo
added
lgtm
Auto: added by prown with a reviewer LGTMs
and removed
do-not-merge/hold
Do not merge: held by author or reviewer.
labels
Oct 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1081 Release Note