Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

allow for default days since symptom onset #1060

Merged
merged 3 commits into from
Oct 6, 2020
Merged

allow for default days since symptom onset #1060

merged 3 commits into from
Oct 6, 2020

Conversation

mikehelmick
Copy link
Contributor

Fixes #1055

Proposed Changes

  • By default, if no value is known for days since symptom onset is known, set it to the default value in the system.
  • 10 is the agreed upon default by the Google and Apple clinical teams

Release Note

BEHAVIOR CHANGE: 
Two new environment variables, USE_DEFAULT_SYMPTOM_ONSET_DAYS and DEFAULT_SYMPTOM_ONSET_DAYS. 
If enabled, TEKs that previously would have a null value for days since symptom onset will receive the default value.

This new functionality is enabled by default in this release.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 6, 2020
@google-oss-robot google-oss-robot added approved Auto: added by prow when enough reviewers approve. size/L Auto: large number of changes. labels Oct 6, 2020
sethvargo
sethvargo approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Oct 6, 2020
@google-oss-robot google-oss-robot removed the lgtm Auto: added by prown with a reviewer LGTMs label Oct 6, 2020
@sethvargo
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Oct 6, 2020
@google-oss-robot google-oss-robot removed the lgtm Auto: added by prown with a reviewer LGTMs label Oct 6, 2020
sethvargo
sethvargo approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Oct 6, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 77094b3 into google:main Oct 6, 2020
@mikehelmick mikehelmick deleted the issue1055 branch October 6, 2020 20:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@icco icco Awaiting requested review from icco

Assignees

@sethvargo sethvargo

Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/L Auto: large number of changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default days since symptom onset handling
3 participants
@mikehelmick @sethvargo @google-oss-robot