Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Clean up CMake #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up CMake #1

wants to merge 1 commit into from

Conversation

curtpm
Copy link

@curtpm curtpm commented Sep 16, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

set (CMAKE_CXX_STANDARD 11)
IF (APPLE)
set (CMAKE_CXX_FLAGS "-I/usr/include/i386-linux-gnu/c++/4.8 -I/usr/include/c++/4.8 -std=c++11 -g3 -Wall -O3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss the c++11 flag?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the CXX_STANDARD_REQUIRED flag.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both CMAKE_CXX_STANDARD and CXX_STANDARD_REQUIRED require min cmake 3.1 so cmake_minimum_required should be bumped too.

require c++11 standard
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@curtpm
Copy link
Author

curtpm commented Sep 19, 2016

I signed it!

@PaulRashidi
Copy link
Contributor

Please read the above carefully. You may be creating commit messages with one email address and signing the CLA with another email address. If this isn't the case, after you've double checked, let us know and we'll look into it.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants