-
Notifications
You must be signed in to change notification settings - Fork 122
Clean up CMake #1
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
set (CMAKE_CXX_STANDARD 11) | ||
IF (APPLE) | ||
set (CMAKE_CXX_FLAGS "-I/usr/include/i386-linux-gnu/c++/4.8 -I/usr/include/c++/4.8 -std=c++11 -g3 -Wall -O3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss the c++11 flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the CXX_STANDARD_REQUIRED flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both CMAKE_CXX_STANDARD and CXX_STANDARD_REQUIRED require min cmake 3.1 so cmake_minimum_required should be bumped too.
require c++11 standard
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it! |
Please read the above carefully. You may be creating commit messages with one email address and signing the CLA with another email address. If this isn't the case, after you've double checked, let us know and we'll look into it. Thanks! |
No description provided.