Moe Sync #933
Merged
Moe Sync #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, emit one find (and fix) for each method. This makes the findings more useful if they are only shown on changed lines, since we don't know which method was added by the change. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185201382
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185206301
RELNOTES: Disallow Error Prone BugPattern names that includes spaces. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185215138
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185218710
Loading different implementations of a check is still disallowed, but we can now tolerate e.g. loading the same check both as a built-in and as a plugin. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185219339
reference Fixes #789 RELNOTES: Fixed false positive in ConstructorLeaksThis ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185219776
- Flag maps created using common factory methods. Fixes #921 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185225022
* use latest version of net.ltgt.apt plugin and its new annotationProcessor configuration (will be built into Gradle 4.6, no plugin needed) * use errorprone snapshot version in examples/gradle * use Gradle plugins DSL in examples/plugin/gradle * use new way (as of net.ltgt.errorprone 0.0.9, which is already a bit old) of declaring errorprone dependency in examples/plugin/gradle * update auto-service to latest version Fixes #931 RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185382558
RELNOTES: none ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185398268
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185401130
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Don't batch UngroupedOverload findings
Instead, emit one find (and fix) for each method. This makes the findings more
useful if they are only shown on changed lines, since we don't know which method
was added by the change.
RELNOTES: N/A
0657c99
Also accept ErrorProne @GuardedBy
88906c9
Disallow BugPattern names that includes spaces.
RELNOTES: Disallow Error Prone BugPattern names that includes spaces.
9b5899c
Fix qualified method access in MethodCanBeStatic
RELNOTES: N/A
cd5eab0
Handle duplicates when merging ScannerSuppliers
Loading different implementations of a check is still disallowed, but we can now
tolerate e.g. loading the same check both as a built-in and as a plugin.
RELNOTES: N/A
1d65cf6
Prevent `ConstructorLeaksThis` false positive on constructor reference
Fixes #789
RELNOTES: Fixed false positive in ConstructorLeaksThis
7fe83a2
Recognize more `URLEqualsHashCode` violations
Fixes #921
RELNOTES: N/A
062e0bc
Update Gradle examples
and its new annotationProcessor configuration
(will be built into Gradle 4.6, no plugin needed)
is already a bit old) of declaring errorprone
dependency in examples/plugin/gradle
Fixes #931
RELNOTES: N/A
4e538e0
Fix small precondition bug in ErrorProne method matcher.
RELNOTES: none
b8aa4e5
Fix minor typo in DateFormatConstant
fc0ff5f