MOE Sync 2020-05-13 #1613
MOE Sync 2020-05-13 #1613
Conversation
see https://bugs.openjdk.java.net/browse/JDK-8241780 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311176345
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311191429
*** Original change description *** Update @FormatMethod and @FormatString javadoc see https://bugs.openjdk.java.net/browse/JDK-8241780 *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311200059
RELNOTES: Flag IdentityHashMap construction with boxed types ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311206456
and move the processor dependencies to `<annotationProcessorPaths>`. Fixes #1587 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311225943
The MutablePublicArray check throws a NPE when examining an array that's initialized during a static init block. Add a test case Fixes #1586 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311230609
The java compiler does not allow `-source` and `-target` to be specified explicitly when `--release` is [1], but does add them in response to passing `--release` [2]. As such `SuggestedFixes#compilesWithFix` must compensate for this by removing `-source` and `-target` before triggering another compilation round. Fixes #1265. [1] https://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java#l297 Fixes #1473 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311235043
Fixes #1602 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311248742
…t/values. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311283920
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Update @FormatMethod and @FormatString javadoc
see https://bugs.openjdk.java.net/browse/JDK-8241780
d2b9313
Discourage extracting format strings to single-use constants
0cc0b6c
Automated g4 rollback of changelist 311176345.
*** Original change description ***
Update @FormatMethod and @FormatString javadoc
see https://bugs.openjdk.java.net/browse/JDK-8241780
f52ced1
Flag IdentityHashMap construction with boxed types
RELNOTES: Flag IdentityHashMap construction with boxed types
8801e48
Depend on auto-value-annotations and auto-service-annotations
and move the processor dependencies to
<annotationProcessorPaths>.Fixes #1587
e5e2c10
Fix NPE in MutablePublicArray check
The MutablePublicArray check throws a NPE when examining
an array that's initialized during a static init block. Add a test case
Fixes #1586
e408026
Handle `--release` in compilesWithFix
The java compiler does not allow
-sourceand-targetto be specifiedexplicitly when
--releaseis [1], but does add them in response topassing
--release[2]. As suchSuggestedFixes#compilesWithFixmustcompensate for this by removing
-sourceand-targetbeforetriggering another compilation round.
Fixes #1265.
[1] https://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java#l297
Fixes #1473
cd83ca9
Bump caffeine version to 2.8.0
Fixes #1602
8e9447d
Detect modifications to a Map while iterating over its keySet/entrySet/values.
21dc511