Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Prone should fail on non-existing flag #1275

Closed
thalescm opened this issue May 6, 2019 · 0 comments · Fixed by #2080
Closed

Error Prone should fail on non-existing flag #1275

thalescm opened this issue May 6, 2019 · 0 comments · Fixed by #2080

Comments

@thalescm
Copy link

thalescm commented May 6, 2019

Passing a non-existing flag doesn't fail ErrorProne.
For example: passing -XepDisableAllWarnings (which doesn't exist), Error Prone will ignore it and continue to run normally. This is specially warning as this can potentially cause a lot of false positives if you accidentally add any configuration as a typo.
copybara-service bot pushed a commit that referenced this issue Jan 8, 2021
@cushon
Reject unrecognized flags that start with -Xep
deaea9d 
Fixes #1275

PiperOrigin-RevId: 350621866
@copybara-service copybara-service bot mentioned this issue Jan 8, 2021
Merged
@pzygielo pzygielo mentioned this issue Jan 13, 2021
Closed
stevie400 pushed a commit to HubSpot/error-prone that referenced this issue Jan 15, 2021
@cushon @stevie400
Reject unrecognized flags that start with -Xep
50f7ecd 
Fixes google#1275

PiperOrigin-RevId: 350823043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject unrecognized flags that start with -Xep google/error-prone
1 participant
@thalescm