Fix consistency of isCovered() in CheckReturnValue

PiperOrigin-RevId: 439392998
google · Apr 4, 2022 · fba919b · fba919b
1 parent 2ea4d44
commit fba919b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/CheckReturnValue.java b/core/src/main/java/com/google/errorprone/bugpatterns/CheckReturnValue.java
@@ -110,7 +110,9 @@ private static Optional<MethodSymbol> methodSymbol(ExpressionTree tree) {
 
   @Override
   public boolean isCovered(ExpressionTree tree, VisitorState state) {
-    return methodSymbol(tree).flatMap(CheckReturnValue::firstAnnotation).isPresent();
+    return methodSymbol(tree)
+        .map(m -> (checkAllConstructors && m.isConstructor()) || firstAnnotation(m).isPresent())
+        .orElse(false);
   }
 
   @Override