Add Guice extensions to cirvlist.

Also update `Api#parse()` to accept class names with `-` in them. PiperOrigin-RevId: 496717232
google · Dec 20, 2022 · b4e8d5b · b4e8d5b
1 parent 2a82a27
commit b4e8d5b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/Api.java b/core/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/Api.java
@@ -150,6 +150,9 @@ String owningType() {
           case '.':
             // OK, separator
             break;
+          case '-':
+            // OK, used in Kotlin JvmName to prevent Java users.
+            break;
           default:
             checkArgument(
                 isJavaIdentifierPart(next),

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/checkreturnvalue/ApiTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/checkreturnvalue/ApiTest.java
@@ -148,4 +148,16 @@ public void parseApi_methodWithVarargs_b231250004() {
     assertThat(api.isConstructor()).isTrue();
     assertThat(api.toString()).isEqualTo(string);
   }
+
+  @Test
+  public void parseApi_kotlinClassWithJvmName() {
+    String string = "com.google.inject.-GuiceExtensions#bind(com.google.inject.AbstractModule)";
+    Api api = Api.parse(string);
+
+    assertThat(api.className()).isEqualTo("com.google.inject.-GuiceExtensions");
+    assertThat(api.methodName()).isEqualTo("bind");
+    assertThat(api.parameterTypes()).containsExactly("com.google.inject.AbstractModule");
+    assertThat(api.isConstructor()).isFalse();
+    assertThat(api.toString()).isEqualTo(string);
+  }
 }