Fix an NPE in SetUnrecognized

Fixes #4475 PiperOrigin-RevId: 653339273
google · Jul 17, 2024 · 81d3127 · 81d3127
1 parent bc33976
commit 81d3127
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/SetUnrecognized.java b/core/src/main/java/com/google/errorprone/bugpatterns/SetUnrecognized.java
@@ -50,6 +50,9 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
     }
     ExpressionTree arg = tree.getArguments().get(0);
     var argSymbol = getSymbol(arg);
+    if (argSymbol == null) {
+      return NO_MATCH;
+    }
     if (!argSymbol.getSimpleName().contentEquals("UNRECOGNIZED")) {
       return NO_MATCH;
     }

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SetUnrecognizedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SetUnrecognizedTest.java
@@ -56,4 +56,19 @@ public void negative() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void negativeNotEnum() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import com.google.errorprone.bugpatterns.proto.Proto3Test.TestProto3Enum;",
+            "import com.google.errorprone.bugpatterns.proto.Proto3Test.TestProto3Message;",
+            "class Test {",
+            "  void test() {",
+            "    TestProto3Message.newBuilder().setMyString(\"\");",
+            "  }",
+            "}")
+        .doTest();
+  }
 }