UngroupedOverloads: ignore generated constructors

Fixes #3404. Fixes #3632 COPYBARA_INTEGRATE_REVIEW=#3632 from PicnicSupermarket:bugfix/issue-3404 897aa79 PiperOrigin-RevId: 498743314
google · Dec 31, 2022 · 4fa8720 · 4fa8720
1 parent 721096f
commit 4fa8720
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UngroupedOverloads.java b/core/src/main/java/com/google/errorprone/bugpatterns/UngroupedOverloads.java
@@ -96,7 +96,9 @@ public Description matchClass(ClassTree classTree, VisitorState state) {
       Tree member = classTree.getMembers().get(i);
       if (member instanceof MethodTree) {
         MethodTree methodTree = (MethodTree) member;
-        methods.put(OverloadKey.create(methodTree), MemberWithIndex.create(i, methodTree));
+        if (!ASTHelpers.isGeneratedConstructor(methodTree)) {
+          methods.put(OverloadKey.create(methodTree), MemberWithIndex.create(i, methodTree));
+        }
       }
     }
     ImmutableList<Description> descriptions =

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UngroupedOverloadsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UngroupedOverloadsTest.java
@@ -16,10 +16,13 @@
 
 package com.google.errorprone.bugpatterns;
 
+import static org.junit.Assume.assumeTrue;
+
 import com.google.common.collect.ImmutableList;
 import com.google.errorprone.BugCheckerRefactoringTestHelper;
 import com.google.errorprone.BugCheckerRefactoringTestHelper.TestMode;
 import com.google.errorprone.CompilationTestHelper;
+import com.google.errorprone.util.RuntimeVersion;
 import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -287,4 +290,22 @@ public void describingConstructors() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void recordConstructor() {
+    assumeTrue(RuntimeVersion.isAtLeast16());
+
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import com.google.common.collect.ImmutableSet;",
+            "import java.util.Set;",
+            "",
+            "record MyRecord(ImmutableSet<String> strings) {",
+            "  MyRecord(Set<String> strings) {",
+            "    this(strings == null ? ImmutableSet.of() : ImmutableSet.copyOf(strings));",
+            "  }",
+            "}")
+        .doTest();
+  }
 }