Add a test case demonstrating a CanIgnoreReturnValueSuggester bug.

PiperOrigin-RevId: 607088772
google · Feb 14, 2024 · 4f060e1 · 4f060e1
1 parent a1f4fa7
commit 4f060e1
Showing 1 changed file with 45 additions and 0 deletions.
diff --git a/...com/google/errorprone/bugpatterns/checkreturnvalue/CanIgnoreReturnValueSuggesterTest.java b/...com/google/errorprone/bugpatterns/checkreturnvalue/CanIgnoreReturnValueSuggesterTest.java
@@ -924,4 +924,49 @@ public void anonymous() {
         .expectUnchanged()
         .doTest();
   }
+
+  @Test
+  public void returningANewInstance() {
+    helper
+        .addInputLines(
+            "MyBuilder.java",
+            "public final class MyBuilder {",
+            "  MyBuilder() { }",
+            "  MyBuilder(String name) { }",
+            "  MyBuilder(MyBuilder builder) { }",
+            "  public MyBuilder passingParam(String name) {",
+            "    return new MyBuilder(name);",
+            "  }",
+            "  public MyBuilder passingThis() {",
+            "    return new MyBuilder(this);",
+            "  }",
+            "  public MyBuilder notPassing() {",
+            "    return new MyBuilder();",
+            "  }",
+            "}")
+        .addOutputLines(
+            "MyBuilder.java",
+            "import com.google.errorprone.annotations.CanIgnoreReturnValue;",
+            "public final class MyBuilder {",
+            "  MyBuilder() { }",
+            "  MyBuilder(String name) { }",
+            "  MyBuilder(MyBuilder builder) { }",
+            // TODO(b/325282579): this is a bug! we should not recommend @CIRV here!
+            "  @CanIgnoreReturnValue",
+            "  public MyBuilder passingParam(String name) {",
+            "    return new MyBuilder(name);",
+            "  }",
+            // TODO(b/325282579): this is a bug! we should not recommend @CIRV here!
+            "  @CanIgnoreReturnValue",
+            "  public MyBuilder passingThis() {",
+            "    return new MyBuilder(this);",
+            "  }",
+            // TODO(b/325282579): this is a bug! we should not recommend @CIRV here!
+            "  @CanIgnoreReturnValue",
+            "  public MyBuilder notPassing() {",
+            "    return new MyBuilder();",
+            "  }",
+            "}")
+        .doTest();
+  }
 }