InvalidThrows: don't crash if @throws references elements that aren't…

… classes PiperOrigin-RevId: 530175878
google · May 8, 2023 · 2000ac2 · 2000ac2
1 parent 87d0f20
commit 2000ac2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/javadoc/InvalidThrows.java b/core/src/main/java/com/google/errorprone/bugpatterns/javadoc/InvalidThrows.java
@@ -33,6 +33,7 @@
 import com.sun.source.util.DocTreePathScanner;
 import com.sun.tools.javac.api.JavacTrees;
 import com.sun.tools.javac.code.Type;
+import com.sun.tools.javac.code.TypeTag;
 import javax.lang.model.element.Element;
 
 /**
@@ -84,7 +85,8 @@ public Void visitThrows(ThrowsTree throwsTree, Void unused) {
     }
 
     private boolean isCheckedException(Type type) {
-      return !state.getTypes().isAssignable(type, state.getSymtab().errorType)
+      return type.hasTag(TypeTag.CLASS)
+          && !state.getTypes().isAssignable(type, state.getSymtab().errorType)
           && !state.getTypes().isAssignable(type, state.getSymtab().runtimeExceptionType);
     }
   }

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidThrowsTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidThrowsTest.java
@@ -84,4 +84,20 @@ public void unrecognisedException_noComplaint() {
         .expectUnchanged()
         .doTest(TestMode.TEXT_MATCH);
   }
+
+  @Test
+  public void throwsInvalidType() {
+    refactoring
+        .addInputLines(
+            "Test.java",
+            "interface Test {",
+            "  /**",
+            "   * @throws bar when failed",
+            "   */",
+            "  void foo();",
+            "  void bar();",
+            "}")
+        .expectUnchanged()
+        .doTest(TestMode.TEXT_MATCH);
+  }
 }