Recognize libcore.util.Nullable as type-use, and add a TODO about "hy…

…brid" annotations. PiperOrigin-RevId: 407607800
google · Nov 4, 2021 · 0fc9146 · 0fc9146
1 parent 0f34024
commit 0fc9146
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/nullness/NullnessUtils.java b/core/src/main/java/com/google/errorprone/bugpatterns/nullness/NullnessUtils.java
@@ -237,7 +237,12 @@ private static NullableAnnotationToUse pickNullableAnnotation(VisitorState state
   }
 
   private static boolean isTypeUse(String className) {
+    /*
+     * TODO(b/205115472): Make this tri-state ({type-use, declaration, both}) and avoid using "both"
+     * annotations in any cases in which they would be ambiguous (e.g., arrays/elements).
+     */
     switch (className) {
+      case "libcore.util.Nullable":
       case "org.checkerframework.checker.nullness.qual.Nullable":
       case "org.jspecify.nullness.Nullable":
         return true;