Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add w3c_webcrypto support #131

Open
sumo opened this issue Sep 23, 2019 · 1 comment
Open

Add w3c_webcrypto support #131

sumo opened this issue Sep 23, 2019 · 1 comment

Comments

@sumo
Copy link

sumo commented Sep 23, 2019

I am trying to add webcrypto support but I cannot get the project to build with bazel - will raise another issue.

I have attached the patch that (I think) adds webcrypto. Hopefully it will be quicker for you to apply and release rather than me to get my build issue fixed.
0001-Attempt-to-add-web-crypto.patch.txt

@realityforge
Copy link
Collaborator

It looks like there are a few things still need to be addressed in this patch. I would recommend getting Bazel building and then look at the CONTRIBUTING.md document in the sections "Providing a specific numeric type for a JavaScript API" and "Providing parameter names". I tend to go through a few rounds of generating the API, clean up integers/parameter names. Potentially cleanup externs in closure compiler to add more useful typing. And when thats ready get a release going.

I know the j2cl/elemental2 team is trying to get an elemental2 release happening atm but if you miss that round I tend to release versions to maven central when there is demand.

kohlschuetter added a commit to kohlschutter/elemental2 that referenced this issue Aug 20, 2024
This currently requires building with our modified jsinterop-generator.

Also see
google#131
kohlschuetter added a commit to kohlschutter/jacline that referenced this issue Aug 20, 2024
kohlschuetter added a commit to kohlschutter/jsinterop-generator that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants