Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hundreds compiler warnings #411 #418

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Conversation

FreddyFunk
Copy link
Contributor

The whole draco project compiled in debug mode with over 900 compiler warings in Visual Studio before due to inappropriate casts in most cases. Mosts of them are fixed with this pull request. Now there are only around 120 compiler warnings left.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tomfinegan
Copy link
Contributor

@FreddyFunk: Thanks for the PR. I'm really sorry to point this out, but we can't accept this PR as-is. Our coding style guidelines[1] forbid the use of c-style casts.

If you modify the PR to use C++ style casts I can accept it.

Note that you'll have to sign the CLA as well.

[1] https://google.github.io/styleguide/cppguide.html#Casting

@FreddyFunk
Copy link
Contributor Author

Thanks for your fast answer. I will look into the CLA and rework PR for C++ style casts.

@FreddyFunk
Copy link
Contributor Author

I signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@tomfinegan
Copy link
Contributor

@FreddyFunk

Thanks for updating this PR, and sorry for the latency. I'll try to get this merged in next week. I've been on break (along with some other members of the team), which has been getting in the way.

@tomfinegan tomfinegan merged commit e3a9d6c into google:master Jul 17, 2018
danielgronlund pushed a commit to danielgronlund/draco that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants