Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark-mode] Card shortcode style fixes #1922

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Apr 6, 2024

  • Contributes to Support dark mode #331
  • Adjusts card background styles so as to be compatible with light & dark modes

Preview: https://deploy-preview-1922--docsydocs.netlify.app/docs/adding-content/shortcodes/#shortcode-card-programming-code

Screenshots

Only dark-mode is shown below. The before and after are the same in light mode.

Before (dark mode)

image

After (dark mode)

image

@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@chalin chalin requested a review from deining April 6, 2024 23:36
@chalin chalin mentioned this pull request Apr 6, 2024
26 tasks
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit 4baa6ed into google:main Apr 7, 2024
11 checks passed
@chalin chalin deleted the chalin-im-dark-mode-card-fixes-2024-04-06 branch April 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants