Adjust pageinfo bg to be compatible with dark-mode #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-im-dark-mode-pageinfo-2024-04-05
branch
2 times, most recently
from
0935477 to
79e4063
Compare
chalin
force-pushed
the
chalin-im-dark-mode-pageinfo-2024-04-05
branch
from
79e4063 to
6f3e7eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pageinfobackgrounds compatible with dark-mode by making them match the alert background.Preview: https://deploy-preview-1915--docsydocs.netlify.app/docs/adding-content/shortcodes/#pageinfo
Screenshots (TBC)
Before
Light mode
Dark mode
After
Also notice the tweak in margins.
Light mode
Dark mode
p.s. I know that there's
pageinfowork to be done in the context of #939, but I want to keep focused on wrapping up dark-mode implementation and getting 0.10.0 out.