forked from square/dagger
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hilt ignores Suppress class annotations when generating code #2834
Labels
Comments
I've also tried to use @AndroidEntryPoint
class FooService : @Suppress("deprecation") JobIntentService() { ... } |
Hi, a change supports copying the Suppress annotation will be shipped in a day or two. |
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
copybara-service bot
pushed a commit
that referenced
this issue
Sep 30, 2021
…ting values from Kotlin @Suppress annotations. This CL also adds regression tests that contain @androidentrypoint classes that use Kotlin @Suppress. Fixes #2834 RELNOTES=Fix #2834:Hilt processor now checks the correct "names" property when getting values from Kotlin @Suppress annotations. PiperOrigin-RevId: 399945204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a class is annotated with
@AndroidEntryPoint
annotation the generated class doesn't have@Suppress
annotation the original class has.Steps to reproduce:
@Suppress("deprecation")
, e.g.Expected result
Generated class retains
@Suppress
annotation and no warnings are raised during build.Actual result
Generated class doesn't have
@Suppress
annotation and warning is raised during the build process, e.g.with warning produced during build:
The text was updated successfully, but these errors were encountered: