Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Bump httplib2 to 0.12.0 #134

Closed
wants to merge 1 commit into from
Closed

Bump httplib2 to 0.12.0 #134

wants to merge 1 commit into from

Conversation

gertvdijk
Copy link

Notable improvement is the way it looks up a CA cert bundle; this version introduces support for setting a custom CA cert bundle path using the environment variable HTTPLIB2_CA_CERTS.

See also httplib2/httplib2#2 (comment).

Assuming that your custom organization CA is added to your system CA bundle already, you could point it to your system bundle with a system-wide environment variable, e.g. on Debian:

$ echo 'export HTTPLIB2_CA_CERTS=/etc/ssl/certs/ca-certificates.crt' > /etc/profile.d/httplib2.sh

(And then re-login to activate the changes.)

The above approach might be a simpler alternative to PRs #89 and #52.

Notable improvement is the way it looks up a CA cert bundle; this version
introduces support for setting a custom CA cert bundle path using the
environment variable HTTPLIB2_CA_CERTS.
@ali5h
Copy link

ali5h commented Feb 6, 2019

any update on this?

@gertvdijk
Copy link
Author

It look like no PRs in this repository are being considered and builds all fail. I see that PRs by members are merged though (#133), so perhaps we should just kindly ask...

Hi @KaylaNguyen, could you please review this PR? Thanks.

@ali5h
Copy link

ali5h commented Feb 7, 2019

for now I am building puller.par manually and loading it before rules_docker, which fixed the problem

@jonjohnsonjr
Copy link
Contributor

Fixed by #160

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants