Remove error handling from expression evaluation exercise #2517
+14
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomPoison
requested review from
djmitche and
mgeisler
and removed request for
djmitche
djmitche
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be good to simplify the expression evaluation exercise by removing the error handling around the divide-by-zero case. I think it overcomplicates the exercise and and adds confusion since at this point we haven't introduced
Result(or at least not in any detail). This allows the students to just focus on writing the pattern matches onExpressionandOp, and allows the exercise to be shorter (and I think we need to free up some time where we can, my classes often run long and cut into how much time students have for exercises).