Add "Execution: Add stderr block" again #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d2bde6.
qwandor
approved these changes
Dec 6, 2024
|
I tested it locally and it's good from my side. Because of the unstable problem, @mgeisler can you also test again in your personal build? Just in case we need to rollback it again. |
Yes, I tested it here and it works fine! Thanks for testing it too. With #2462 solved, we should add a little JavaScript test next to ensure the functionality doesn't regress unexpectedly. |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2479, which is a revert of #2397.
I think the problem was not related to @Alx-Lai's change, the Playground was slow for everyone.