Add missing docstring to birthday server implementation #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, compilation fails. The comment *is* in the included Rust file — but we only include a fraction of the file to keep the example short. This makes it cumbersome to both show something that works in the slides while also making it possible for the instructor to show more complex examples.
mgeisler
added a commit
that referenced
this pull request
Nov 19, 2024
Without this, students will see subtle differences between what is on the slides and what we have in the code (see #2464 for an example).
mgeisler
added a commit
that referenced
this pull request
Nov 19, 2024
Without this, students will see subtle differences between what is on the slides and what we have in the code (see #2464 for an example).
|
Hi @randomPoison, please take a look at this one. It was reported by an internal student and I would like to see it fixed. |
|
Ah sorry, I saw this PR but spaced on responding to it. I agree that simpler examples would be better. I can address that when I have time to go back over the Android code and make sure everything compiles and works as part of AOSP (though I unfortunately have not had much time for that). For now this looks like a good change 👍 |
randomPoison
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, compilation fails. The comment is in the included Rust file — but we only include a fraction of the file to keep the example short. This makes it cumbersome to both show something that works in the slides while also making it possible for the instructor to show more complex examples.
@randomPoison, we need to make our examples simpler here: the complexity here makes it hard to modify the files and I feel it's hard to show during class. I would suggest splitting this up into a very basic example (what the birthday service was) and then add 1-2 slides with more complex samples (if necessary). Last I taught the class, I had a hard time a) making every example compile and b) finding time to cover everything.
I would err on the side of makings things simple and clear.