Evaluate if the embedded code examples have a visible scrollbar #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion when there are many redirects
…nction and remove the actual size from the result
… visible ace_scrollbar-[hv]
michael-kerscher
force-pushed
the
main
branch
from
4f1bf32 to
111d0c1
Compare
michael-kerscher
force-pushed
the
main
branch
2 times, most recently
from
7d58535 to
111d0c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the idea I drafted in #2012 (comment)
If the embedded code examples, shown in the ACE editor have any visible scrollbar (vertical or horizontal), the evaluator indicates this with
CodeExampleVScrollbarorCodeExampleHScrollbarin the result.Additionally ignore the default mdbook redirect pages. These render in the browser but looking at the canonical pages is enough and there is a massive speedup when evaluating the entire book.
The previous version showed the size of the main content element in the result. This is not really relevant as only violations to the policy are of interest, so the size was removed from the result.
the open pull request #2013 also references this idea