Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unsafe trait example to zerocopy version 0.8 #2434

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Update unsafe trait example to zerocopy version 0.8 #2434

merged 7 commits into from
Nov 4, 2024

Conversation

semihbkgr
Copy link
Contributor

Zerocopy crate version 0.8 introduced changes to its API, which caused the example code to break.
google/zerocopy#1680

AsBytes -> IntoBytes

@mgeisler mgeisler changed the title Update unsafe trait example to address zerocopy API changes in version 0.8 Update unsafe trait example zerocopy version 0.8 Oct 16, 2024
@mgeisler mgeisler changed the title Update unsafe trait example zerocopy version 0.8 Update unsafe trait example to zerocopy version 0.8 Oct 16, 2024
@semihbkgr semihbkgr requested a review from mgeisler October 16, 2024 15:06
@mgeisler
Copy link
Collaborator

Hi @semihbkgr, please run dprint fmt to fix the formatting (or apply it by hand from the output of the failing test). Then we can merge this!

@mgeisler mgeisler enabled auto-merge (squash) October 18, 2024 07:11
@mgeisler
Copy link
Collaborator

Thanks for the help, this is super useful!

auto-merge was automatically disabled October 18, 2024 20:02

Head branch was pushed to by a user without write access

@mgeisler
Copy link
Collaborator

mgeisler commented Nov 1, 2024

Now that the example uses &raw, it's breaking because the GH runners don't have the very latest stable version of Rust. That will be fixed by #2449.

@qwandor qwandor merged commit b4f07ba into google:main Nov 4, 2024
35 checks passed
This was referenced Dec 12, 2024
Closed
Merged
qwandor added a commit that referenced this pull request Dec 13, 2024
@qwandor
Fix example from zerocopy. (#2511)
fbeef48 
This was changed incorrectly in #2434.

Fixes #2472.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fw-immunant fw-immunant fw-immunant left review comments

@mgeisler mgeisler mgeisler approved these changes

@qwandor qwandor qwandor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semihbkgr @mgeisler @qwandor @fw-immunant