Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vi: block-n-scopes/...md translations #2073

Merged
merged 11 commits into from
Jul 2, 2024
Merged

vi: block-n-scopes/...md translations #2073

merged 11 commits into from
Jul 2, 2024

Conversation

HuyNVuong
Copy link
Contributor

No description provided.

@HuyNVuong HuyNVuong requested a review from daivinhtran as a code owner May 10, 2024 21:28
vohoanglong0107
vohoanglong0107 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@vohoanglong0107 vohoanglong0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation is really good, just left a few comment on some portion to make the translation clearer.

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
@HuyNVuong HuyNVuong requested a review from qu-ngx as a code owner May 31, 2024 21:10
qu-ngx
qu-ngx approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! This translation already looks good. Thank you so much for your contributions.

@qu-ngx qu-ngx merged commit 176e950 into google:main Jul 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vohoanglong0107 vohoanglong0107 vohoanglong0107 left review comments

@qu-ngx qu-ngx qu-ngx approved these changes

@daivinhtran daivinhtran Awaiting requested review from daivinhtran daivinhtran is a code owner

Assignees
No one assigned
Labels
translation/vi translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HuyNVuong @daivinhtran @vohoanglong0107 @qu-ngx