Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: Welcome - Using Cargo translation #1951

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

khoaxuantu
Copy link
Contributor

Here is the translation of Welcome to Comprehensive Rust: (2) Using Cargo.

@mgeisler
Copy link
Collaborator

mgeisler commented Apr 5, 2024

Hi @khoaxuantu, thanks for the PR!

@daivinhtran, will you be able to review this?

I'm not sure why the tests failed for unrelated languages, but perhaps something broke in our PDF publishing setup... I've restarted the tests and we'll then have to investigate more if they break again.

Copy link
Collaborator

@daivinhtran daivinhtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgeisler yes, I was actually going to review this today.

@mgeisler
Copy link
Collaborator

mgeisler commented Apr 7, 2024

Thanks @daivinhtran! I see that something is broken in the PDF generation:

  2024-04-03 17:00:00 [INFO] (mdbook::renderer): Invoking the "pandoc" renderer
  Warning:  Could not convert image /tmp/tex2pdf.-b8d581420691af04/9b1e09f6511f387768da72145790446bd7e7cf63.vs: Cannot load file
    Jpeg Invalid marker used
    PNG Invalid PNG file, signature broken
    Bitmap Invalid Bitmap magic identifier
    GIF Invalid Gif signature : error 
    HDR Invalid radiance file signature
    Tiff Invalid endian tag value
    TGA not enough bytes
  Error producing PDF.
  ! LaTeX Error: Unknown graphics extension: .vs.
  
  See the LaTeX manual or LaTeX Companion for explanation.
  Type  H <return>  for immediate help.
   ...                                              
                                                    
  l.168 ...1e09f6511f387768da72145790446bd7e7cf63.vs}}
  
  pandoc exited unsuccessfully

Let me create a bug for this so we can start merging these PRs.

@mgeisler
Copy link
Collaborator

mgeisler commented Apr 7, 2024

Actually, #1911 is for that!

Now that I read the issue more carefully, this seems to be about local build errors. I created #1960 for the CI issues.

@mgeisler mgeisler merged commit 611af00 into google:main Apr 8, 2024
34 checks passed
@mgeisler
Copy link
Collaborator

mgeisler commented Apr 8, 2024

It's merged, thanks @daivinhtran for the review — and of course, thank you @khoaxuantu for writing the translation!

@khoaxuantu khoaxuantu deleted the vi-cargo branch April 21, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants