Saving playground code state #1917
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,3 +36,33 @@ | |
| } | ||
| }); | ||
| })(); | ||
|
|
||
| function setCodeToPlayground() { | ||
| var codes = JSON.parse(localStorage.getItem(window.location.href)); | ||
| if (codes) { | ||
| var i = 0; | ||
| Array.from(document.querySelectorAll(".playground")).forEach(function ( | ||
| pre_block | ||
| ) { | ||
| let code_block = pre_block.querySelector("code"); | ||
| let editor = window.ace.edit(code_block); | ||
| editor.setValue(codes[i]); | ||
| editor.clearSelection(); | ||
| i += 1; | ||
| }); | ||
| } | ||
| } | ||
| setCodeToPlayground(); | ||
|
There was a problem hiding this comment. minor point: this is a bit hard to spot here. Please move the whole thing to an IIFE, like the red-box functionality, and put the immediately-evaluated statements at the bottom: (function savePlaygrounds() {
function setCodeToPlayground() ..
function getCodeFromPlaground() ..
setCodeToPlayground();
setInterval(getCodeFromPlayground, 900);
})() |
||
| function getCodeFromPlayground() { | ||
| var codes = []; | ||
| Array.from(document.querySelectorAll(".playground")).forEach(function ( | ||
| pre_block | ||
| ) { | ||
| let code_block = pre_block.querySelector("code"); | ||
| let editor = window.ace.edit(code_block); | ||
| let code = editor.getValue(); | ||
| codes.push(code); | ||
| }); | ||
| localStorage.setItem(window.location.href, JSON.stringify(codes)); | ||
| } | ||
| setInterval(getCodeFromPlayground, 900); | ||
|
There was a problem hiding this comment. This seems like it will wake up the browser frequently even if nothing has changed. I wonder if we could either do this on some event indicating the browser is navigating away (maybe https://developer.mozilla.org/en-US/docs/Web/API/Window/pagehide_event?) or on a timer after the user has modified something in the editor. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought you meant adding a new JS file for this functionality, rather than moving the existing red-box functionality too. Maybe keep
theme/redbox.jsand move this new functionality intotheme/save-playgrounds.js?