Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some spanish translations and fix translations #1790

Merged

Conversation

Michael-Liendo
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Feb 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Michael-Liendo Michael-Liendo marked this pull request as ready for review February 6, 2024 20:44
Copy link
Collaborator

@deavid deavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to make the Pull request smaller? +4000 lines isn't something I can manage.

@Michael-Liendo
Copy link
Contributor Author

Can you try to make the Pull request smaller? +4000 lines isn't something I can manage.

Okay, I'll see why. I am using Poedit

@Michael-Liendo Michael-Liendo requested a review from deavid February 6, 2024 20:54
@Michael-Liendo
Copy link
Contributor Author

Michael-Liendo commented Feb 6, 2024

Sorry, I needed to format the code! Ready to review @deavid

po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
@Michael-Liendo Michael-Liendo requested a review from deavid February 6, 2024 21:51
@Michael-Liendo
Copy link
Contributor Author

I change other translations of Arrays to 'Arreglos'

@Michael-Liendo Michael-Liendo requested a review from deavid February 6, 2024 22:13
@deavid deavid merged commit e74970a into google:main Feb 7, 2024
33 checks passed
@Michael-Liendo Michael-Liendo deleted the feat/add-some-spanish-translations branch February 7, 2024 11:44
@mgeisler
Copy link
Collaborator

Can you try to make the Pull request smaller? +4000 lines isn't something I can manage.

Yeah, big PRs suck here. We're looking into using a #1305 instead @GuardsmanPanda has been doing some small trials on this. If you have inputs as well, then let's discuss on #1305.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants