Update mdbook and mdbook-i18n-helpers
#1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also ports over the `mdbook` theme changes between version 0.4.35 and 0.4.36.
qwandor
approved these changes
Jan 5, 2024
| @@ -8,15 +8,15 @@ runs: | |||
| # The --locked flag is important for reproducible builds. It also | |||
| # avoids breakage due to skews between mdbook and mdbook-svgbob. | |||
| - name: Install mdbook | |||
| run: cargo install mdbook --locked --version 0.4.35 | |||
| run: cargo install mdbook --locked --version 0.4.36 | |||
There was a problem hiding this comment.
Is there a corresponding change needed somewhere else to use this version when building locally?
There was a problem hiding this comment.
We tell people to install the latest version and that's normally good enough.
|
Hey @qwandor, thanks for the review!
The theme change is actually backwards compatible — we would just not get the benefits without the theme change. We're probably also a bit unusual in the way that we version one file out of the set of files that make up the theme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also ports over the
mdbooktheme changes between version 0.4.35 and 0.4.36.