-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Mockall and GoogleTest slides to Android section #1533
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Testing in Android | ||
|
||
Building on [Testing](../testing.md), we will now look at how unit tests work in | ||
AOSP. Use the `rust_test` module for your unit tests: | ||
|
||
_testing/Android.bp_: | ||
|
||
```javascript | ||
{{#include testing/Android.bp}} | ||
``` | ||
|
||
_testing/src/lib.rs_: | ||
|
||
```rust | ||
{{#include testing/src/lib.rs:leftpad}} | ||
``` | ||
|
||
You can now run the test with | ||
|
||
```shell | ||
{{#include build_all.sh:libleftpad_test}} | ||
``` | ||
|
||
The output looks like this: | ||
|
||
```text | ||
INFO: Elapsed time: 2.666s, Critical Path: 2.40s | ||
INFO: 3 processes: 2 internal, 1 linux-sandbox. | ||
INFO: Build completed successfully, 3 total actions | ||
//comprehensive-rust-android/testing:libleftpad_test_host PASSED in 2.3s | ||
PASSED libleftpad_test.tests::long_string (0.0s) | ||
PASSED libleftpad_test.tests::short_string (0.0s) | ||
Test cases: finished with 2 passing and 0 failing out of 2 test cases | ||
``` | ||
|
||
Notice how you only mention the root of the library crate. Tests are found | ||
recursively in nested modules. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
rust_library { | ||
name: "libleftpad", | ||
crate_name: "leftpad", | ||
srcs: ["src/lib.rs"], | ||
} | ||
|
||
rust_test { | ||
name: "libleftpad_test", | ||
crate_name: "leftpad_test", | ||
srcs: ["src/lib.rs"], | ||
host_supported: true, | ||
test_suites: ["general-tests"], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
[package] | ||
name = "android-testing" | ||
version = "0.1.0" | ||
edition = "2021" | ||
publish = false | ||
|
||
[[example]] | ||
name = "googletest-example" | ||
crate-type = ["staticlib"] | ||
path = "googletest.rs" | ||
test = true | ||
|
||
[[example]] | ||
name = "mockall-example" | ||
crate-type = ["staticlib"] | ||
path = "mockall.rs" | ||
test = true | ||
|
||
[dependencies] | ||
googletest = "0.11.0" | ||
mockall = "0.12.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2024 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// ANCHOR: leftpad | ||
//! Left-padding library. | ||
|
||
/// Left-pad `s` to `width`. | ||
pub fn leftpad(s: &str, width: usize) -> String { | ||
format!("{s:>width$}") | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
|
||
#[test] | ||
fn short_string() { | ||
assert_eq!(leftpad("foo", 5), " foo"); | ||
} | ||
|
||
#[test] | ||
fn long_string() { | ||
assert_eq!(leftpad("foobar", 6), "foobar"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djmitche, are you happy with this change? I think I might have done the timing information wrong in the moved slides to trigger an integer underflow here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, good point!