Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-TW translation of index.md completed. #1240

Closed
wants to merge 23 commits into from
Closed

Conversation

kochinc
Copy link
Contributor

@kochinc kochinc commented Sep 22, 2023

All srings in index.md are translated.

@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@hueich hueich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, up to line ~1300.

po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
po/zh-TW.po Outdated Show resolved Hide resolved
po/zh-TW.po Outdated Show resolved Hide resolved
po/zh-TW.po Show resolved Hide resolved
@mgeisler mgeisler mentioned this pull request Sep 29, 2023
@henrif75
Copy link
Collaborator

henrif75 commented Oct 2, 2023

Hi @kochinc , thanks for your help!
I'm going to send a few PRs in the next day or two with translations for the Rust Fundamentals. Perhaps you could either review them or continue your work from the Android section and onwards. Please let me know.

@kochinc
Copy link
Contributor Author

kochinc commented Oct 2, 2023

@henrif75 Got it. But it seems that someone has already been working on the Android part according to the spreadsheet.

"POT-Creation-Date: 2023-08-23\n"
"PO-Revision-Date: 2023-06-02 14:43+0800\n"
"Last-Translator: Hank Chen <[email protected]>\n"
"POT-Creation-Date: \n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kochinc, please make sure to run cargo install mdbook-i18n-helpers. That will give you version 0.2.4, which in turns adds this importand header.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1243 for what it does: in basically ensures that you are translating against a fixed version of the course.

@mgeisler
Copy link
Collaborator

Hey @kochinc, do we still need this PR or was it made obsolete by the PRs @henrif75 sent out?

@kochinc
Copy link
Contributor Author

kochinc commented Nov 12, 2023

Hey @kochinc, do we still need this PR or was it made obsolete by the PRs @henrif75 sent out?
Ok. I'll close this. Thanks.

@kochinc kochinc closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants