-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh-TW translation of index.md completed. #1240
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review, up to line ~1300.
Co-authored-by: Addison Luh <[email protected]>
Co-authored-by: Addison Luh <[email protected]>
Co-authored-by: Addison Luh <[email protected]>
Co-authored-by: Addison Luh <[email protected]>
Co-authored-by: Addison Luh <[email protected]>
Apply this suggestion now, but consider 容易地 later. Co-authored-by: Addison Luh <[email protected]>
Hi @kochinc , thanks for your help! |
@henrif75 Got it. But it seems that someone has already been working on the Android part according to the spreadsheet. |
"POT-Creation-Date: 2023-08-23\n" | ||
"PO-Revision-Date: 2023-06-02 14:43+0800\n" | ||
"Last-Translator: Hank Chen <[email protected]>\n" | ||
"POT-Creation-Date: \n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kochinc, please make sure to run cargo install mdbook-i18n-helpers
. That will give you version 0.2.4, which in turns adds this importand header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1243 for what it does: in basically ensures that you are translating against a fixed version of the course.
All srings in index.md are translated.