Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa: add more Persian #1209

Closed
wants to merge 0 commits into from
Closed

fa: add more Persian #1209

wants to merge 0 commits into from

Conversation

DannyRavi
Copy link
Collaborator

@DannyRavi DannyRavi commented Sep 13, 2023

some Persian translations have been added.

Part of #671.

@mgeisler mgeisler changed the title Some Persian translation has been added. fa: add more Persian Sep 14, 2023
@henrif75
Copy link
Collaborator

Hi @DannyRavi thanks for your PR!
I think there's an issue with the sample code in one of your files. You can find it out by running MDBOOK_BOOK__LANGUAGE=fa mdbook test from the root of your project directory.

po/fa.po Outdated Show resolved Hide resolved
@henrif75 henrif75 requested a review from mgeisler September 24, 2023 13:57
@mgeisler
Copy link
Collaborator

Hi @DannyRavi, can you please merge main into your branch? You will get a small merge conflict around the POT-Creation-Date and PO-Revision-Date fields. You should be able to resolve this by hand. The POT-Creation-Date field is updated when you msgmerge new strings into your PO file. It is set by the latest version of mdbook-i18n-helpers, so make sure to cargo install mdbook-i18n-helpers as well to get version 0.2.4.

Then follow the preparation steps for translations to install both msgcat and dprint.

This will let you run dprint fmt to auto-format the fa.po file. Push the whole thing to your branch so you can see that the checks pass.

@DannyRavi
Copy link
Collaborator Author

Hi @mgeisler
I made a small translation on the "fa.po" file and used the "dprint fmt" command, and the problem of line 1027 in the "fa.po" file was solved.
Also, there were problems to install and use "dprint fmt", which was solved by using a proxy.
thank you.

@mgeisler
Copy link
Collaborator

Hi @mgeisler I made a small translation on the "fa.po" file and used the "dprint fmt" command, and the problem of line 1027 in the "fa.po" file was solved. Also, there were problems to install and use "dprint fmt", which was solved by using a proxy. thank you.

I'm glad you could figure it out! Let us know if we need to amend the setup instructions in any way.

I notice you closed the PR? Is that on purpose because you will open a new one? It's completely fine to open a new one — we should then get @javad-jafari added as a reviewer so the two of you can help each other out.

@DannyRavi
Copy link
Collaborator Author

Hi @mgeisler
I probably made a mistake when I closed this Pull request
I can also cooperate with @javad-jafari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants