Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian translation #836

Closed
mgeisler opened this issue Jun 20, 2023 · 28 comments · Fixed by #2183
Closed

Ukrainian translation #836

mgeisler opened this issue Jun 20, 2023 · 28 comments · Fixed by #2183

Comments

@mgeisler
Copy link
Collaborator

mgeisler commented Jun 20, 2023

Thanks @git-user-cpp for starting this in #835. This issue is to track the translation. Please read the instructions linked in #282, in particular, please read the translation instructions and the style guide.

The Rust book has been translated into Ukrainian and it would be good to use its terminology where possible.

If there are many translators, consider using this sheet to coordinate the work. This has been helpful for the Chinese and Japanese translations.

This was referenced Jun 20, 2023
@PetroProtsyk
Copy link

Hi there, I'd be happy to help with translation

@yaremam
Copy link
Contributor

yaremam commented Jun 20, 2023

Hi, would be happy to help

@mgeisler
Copy link
Collaborator Author

Thanks @PetroProtsyk and @yaremam! The first thing to do would be to skim through #835 so we can get it merged. The first commit is always huge, so don't worry about that — we just need the ~73 translated messages proofread and someone needs to click the "Approve" button (anybody can do this).

If you end up being many translators here, then I suggest using the spreadsheet template linked above to coordinate. But it's really up to you — comments on this issue could also be more than enough. I'll let you discuss this with @git-user-cpp.

@dyeroshenko
Copy link
Collaborator

Merged the initial PR and we can start working on improvements in the next iterations. FYI - there is an amazing vocabulary (proudly borrowed from Rustbook Ukrainian repo) we can reuse & contribute to.

@yaremam
Copy link
Contributor

yaremam commented Sep 12, 2023

Is anyone actively working on this? I created the spreadsheet from the template above - https://docs.google.com/spreadsheets/d/10is7_b4dTzHTzzAJB067vG2LGEY-VekJFsaVjV1j6DU/
Please request access and pick your files to translate. I am going to start with welcome.md

@mgeisler
Copy link
Collaborator Author

Hi @yaremam, welcome! I don't think anybody is working actively on this.

Consider using https://github.com/mgeisler/cloud-translate to seed the translation with a machine translation. The results are sometimes hilarious, but sometimes helpful 😄

@mgeisler
Copy link
Collaborator Author

You should start by refreshing the PO file by extracting new strings with a 0.2 version of mdbook-i18n-helpers and then run msgmerge. That will give you a gigantic PR which @henrif75 or myself can auto-approve. After that, you can submit smaller PRs for a while.

@yaremam
Copy link
Contributor

yaremam commented Sep 12, 2023

Can't change the reviewer on the PR to @henrif75 or @mgeisler . Looks like previous version was already using 0.2.2 version of mdbook-i18n-helpers though

@yaremam
Copy link
Contributor

yaremam commented Sep 12, 2023

I think it is best to split the work by ID range, not by source file. I will update the sheet accordingly, let's divide in ranges of 200 strings, so we can merge the work frequently to the master. Looks like these IDs are generated on the fly by poedit, but the id is simply the order of the string in po/uk.po file, so it should be the same for anyone using poedit. WDYT? List of files in the sheet is outdated. @PetroProtsyk @dyeroshenko

@PetroProtsyk
Copy link

Sounds good, I have reserved message ids 401-600

@yaremam
Copy link
Contributor

yaremam commented Sep 19, 2023

Should we try running cloud-translate? Last time I was using google translator to translate US Army manuals to Ukrainian it produced very good results. @PetroProtsyk @dyeroshenko

@thefirans
Copy link
Contributor

Hello guys! I would like to help you with this issue. If there any translations that I can do? @yaremam

@yaremam
Copy link
Contributor

yaremam commented Oct 11, 2023

@thefirans - pick an available range from https://docs.google.com/spreadsheets/d/10is7_b4dTzHTzzAJB067vG2LGEY-VekJFsaVjV1j6DU/ . You can also try cloud-translate as mentioned here - #836 (comment)

@thefirans
Copy link
Contributor

@yaremam - I translated uk.po file using cloud-translate + made some edits to the translation. But I can't run the book with the updated translation, the book still runs on the default localization (even other localizations are not applied). Can you try to run my uk.po file on your computer?

@yaremam
Copy link
Contributor

yaremam commented Oct 13, 2023 via email

@PetroProtsyk
Copy link

Hi @thefirans, I can give it a try. How can I get your translated uk.po?

@thefirans
Copy link
Contributor

Hi @PetroProtsyk - it would be great! Here's my translated uk.po file from my fork - link

@PetroProtsyk
Copy link

Hi @thefirans, I have tried your uk.po file. I have used the following commands:

MDBOOK_BOOK__LANGUAGE=uk mdbook build -d book/uk
MDBOOK_BOOK__LANGUAGE=uk mdbook serve -d book/uk

This will indeed not display many new translations. This is because all of them are marked with fuzzy flag. See: https://github.com/google/mdbook-i18n-helpers/blob/main/i18n-helpers/USAGE.md#using-translations

If you want to see translated text - you should open your uk.po and remove all #, fuzzy lines from it. Once you do this, you will see all translations.

@yaremam
Copy link
Contributor

yaremam commented Oct 23, 2023

I suggest to commit cloud-translate work, and we'll further focus on correcting all fuzzy translations

@thefirans
Copy link
Contributor

Would you mind if I create a PR and commit to the main branch for the cloud-translate work, or is there a specific branch for commits like this? This way, we won't have to translate the uk.po file from scratch.

@yaremam
Copy link
Contributor

yaremam commented Oct 25, 2023

Sure, why not, let's commit to the main branch

@reta
Copy link
Contributor

reta commented Nov 9, 2023

Sure, why not, let's commit to the main branch

@yaremam I would love to help with the translation, would you mind if I work through #1425 to fix the translation? Thank you.

@reta
Copy link
Contributor

reta commented Jun 27, 2024

@mgeisler we are in a good shape to have Ukrainian translation published (final touches are here #2176), what is the process to do that? Thank you!

@henrif75
Copy link
Collaborator

That's great, @reta !
I'll send the PRs to "officially" add the UK translation to the language selector!

@mgeisler
Copy link
Collaborator Author

Amazing work, thanks everyone!

@mgeisler
Copy link
Collaborator Author

Ukrainian is now the language with the most complete translation: https://google.github.io/comprehensive-rust/synced-translation-report.html. The report shows the result of extracting new strings and merging them into the translation file. There is current 71 untranslated strings.

@reta
Copy link
Contributor

reta commented Sep 17, 2024

There is current 71 untranslated strings.

I will take care of it shortly, thanks @mgeisler !

@mgeisler
Copy link
Collaborator Author

Amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants