This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
pull MSI version from environment #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't have version / build numbers anywhere else in the source. Set WIX config to use a environment variable for MSI version also. With this change you can run: export CONNECTOR_VERSION=0.9.1 /c/Program\ Files\ \(x86\)/WiX\ Toolset\ v3.10/bin/candle.exe -arch x64 windows-connector.wxs dependencies.wxs /c/Program\ Files\ \(x86\)/WiX\ Toolset\ v3.10/bin/light.exe -ext "C:\Program Files (x86)\WiX Toolset v3.10\bin\WixUIExtension.dll" -ext WixfirewallExtension windows-connector.wixobj dependencies.wixobj -o windows-connector.msi to dynamically set the MSI version number.
arastooz
approved these changes
Oct 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't have version / build numbers anywhere else in the source. Set WIX config to use a environment variable for MSI version also. With this change you can run:
export CONNECTOR_VERSION=0.9.1
/c/Program\ Files\ (x86)/WiX\ Toolset\ v3.10/bin/candle.exe -arch x64 windows-connector.wxs dependencies.wxs
/c/Program\ Files\ (x86)/WiX\ Toolset\ v3.10/bin/light.exe -ext "C:\Program Files (x86)\WiX Toolset v3.10\bin\WixUIExtension.dll" -ext WixfirewallExtension windows-connector.wixobj dependencies.wixobj -o windows-connector.msi
to dynamically set the MSI version number.