Correct typing of the FetchEvent.preloadResponse property a little.

The spec calls out some cases where this can resolve to undefined, such as navigation preload not being turned on. See the cases where preloadResponse resolves to undefined in this algorithm: https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm Also add targetClientId and reservedClientId to the spec from w3c/ServiceWorker#870 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164604919
google · Aug 8, 2017 · a2f4dee · a2f4dee
1 parent 98f9f37
commit a2f4dee
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/externs/browser/w3c_serviceworker.js b/externs/browser/w3c_serviceworker.js
@@ -591,7 +591,7 @@ function FetchEvent(type, opt_eventInitDict) {}
 FetchEvent.prototype.request;
 
 /**
- * @type {!Promise<Response>}
+ * @type {!Promise<!Response|undefined>}
  */
 FetchEvent.prototype.preloadResponse;
 
@@ -604,11 +604,17 @@ FetchEvent.prototype.client;
 /** @type {?string} */
 FetchEvent.prototype.clientId;
 
+/** @type {?string} */
+FetchEvent.prototype.targetClientId;
+
+/** @type {?string} */
+FetchEvent.prototype.reserveClientId;
+
 /** @type {!boolean} */
 FetchEvent.prototype.isReload;
 
 /**
- * @param {(Response|IThenable<Response>)} r
+ * @param {(Response|IThenable<?Response|undefined>)} r
  * @return {undefined}
  */
 FetchEvent.prototype.respondWith = function(r) {};
@@ -629,7 +635,7 @@ FetchEvent.prototype.default = function() {};
  *   bubbles: (boolean|undefined),
  *   cancelable: (boolean|undefined),
  *   request: (!Request|undefined),
- *   preloadResponse: (!Promise<Response>),
+ *   preloadResponse: (!Promise<?Response|undefined>),
  *   client: (!ServiceWorkerClient|undefined),
  *   isReload: (!boolean|undefined)
  * }}

diff --git a/src/com/google/javascript/jscomp/resources.json b/src/com/google/javascript/jscomp/resources.json