Upgrade to clang 3.7

[gdbelvin]

clang 3.7 / 3.8 is the latest / only compiler available on OSX in the xcode7 toolchain.

Code updates:

• Glog's use of an unused template to implement compile-time checks.
  https://github.com/google/glog/blob/4d391fe692ae6b9e0105f473945c415a3ce5a401/src/glog/logging.h.in#L931
• Unnecessary move() operations in return statements that prevent copy
  elison

Build system updates:

• Update OSX to xcode7
  • Install Python as part of OXS image
  • Fix Go rate limiting - fails on xcode7 image
• Update linux to clang 3.7
  • LLVM APT Repos are currently disabled.

[pphaneuf]

For the glog part, do you know if there is a new version we could simply upgrade to?

[Martin2112]

I think the glog error might be related to -Wno-unused-local-typedefs. I
managed to build on 3.7 with gclient but I had to manually adjust CXXFLAGS.

I had to also add -Wno-pessimizing-moves, which I think is related to your
recent refactorings and we could probably get rid of that one. I think
these warnings all came from cms_verifier.cc.

I also noticed that the generated makefile includes -Wall after CXXFLAGS,
which seems like the wrong way round.

Martin

On 10 June 2016 at 10:43, Pierre Phaneuf [email protected] wrote:

For the glog part, do you know if there is a new version we could simply
upgrade to?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1247 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AMv2T84CRjM4BZg9m4wFk4a0qyC7Blpoks5qKTGvgaJpZM4IyYtn
.

[pphaneuf]

I've got #1237 that shuts up a number of warnings, might help on that front?

[pphaneuf]

I think the thing to do for @gdbelvin (who's not really working on the CT server itself, but is just trying to build it) is to delete the -Wall -Werror at https://github.com/google/certificate-transparency/blob/master/build/configure-ct#L18 and go on his way.

Those are a bit of a bug, we'd ideally want gclient to behave the way configure does: by default not enable extra warnings and errors, because most people just want to build it so they can run it, and give developers (and Travis) a way to enable those for themselves. Having the default be really picky like that is not helping anyone.